This repository was archived by the owner on Dec 11, 2024. It is now read-only.
Repository navigation
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is very much in the is this worth idea phase, not planning on implementing for next version
Currently all connectors and their dependencies are loaded.
Some of these such as Ledger Connector depend on libraries that are not small.
While internally these packages are loading with async import they are still part of the same JS bundle (when bundle react-celo with next.js).
Proposal
A system where Connectors and their modal Screen were packaged up in an object and array of them could be passed as a prop to CeloProvider.
The benefit I see here is that some dapps might decide their target audience doesn't need Ledger for instance. Or if they do the app could load that async and thus breakup app bundle into separate parts which could help with initial loading time
All reactions