diff --git a/src/main/java/org/omnifaces/persistence/model/BaseEntity.java b/src/main/java/org/omnifaces/persistence/model/BaseEntity.java index c64165c..a3718d2 100644 --- a/src/main/java/org/omnifaces/persistence/model/BaseEntity.java +++ b/src/main/java/org/omnifaces/persistence/model/BaseEntity.java @@ -102,7 +102,7 @@ */ @MappedSuperclass @EntityListeners(BaseEntityListener.class) -public abstract class BaseEntity & Serializable> implements Comparable>, Identifiable { +public abstract class BaseEntity & Serializable> implements Comparable>, Identifiable, Serializable { private static final long serialVersionUID = 1L; diff --git a/src/main/java/org/omnifaces/persistence/model/Identifiable.java b/src/main/java/org/omnifaces/persistence/model/Identifiable.java index 61f9335..42e1847 100644 --- a/src/main/java/org/omnifaces/persistence/model/Identifiable.java +++ b/src/main/java/org/omnifaces/persistence/model/Identifiable.java @@ -50,7 +50,7 @@ * @see BaseEntity * @see BaseEntityService */ -public interface Identifiable & Serializable> extends Serializable { +public interface Identifiable & Serializable> { /** * The string representing the field name "id". diff --git a/src/test/java/org/omnifaces/persistence/test/IdentifiableTest.java b/src/test/java/org/omnifaces/persistence/test/IdentifiableTest.java new file mode 100644 index 0000000..9a0757e --- /dev/null +++ b/src/test/java/org/omnifaces/persistence/test/IdentifiableTest.java @@ -0,0 +1,46 @@ +/* + * Copyright OmniFaces + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the + * specific language governing permissions and limitations under the License. + */ +package org.omnifaces.persistence.test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.omnifaces.persistence.test.Serializations.serializeAndDeserialize; + +import java.io.Serializable; + +import org.junit.jupiter.api.Test; +import org.omnifaces.persistence.model.BaseEntity; +import org.omnifaces.persistence.model.Identifiable; +import org.omnifaces.persistence.test.model.Person; + +/** + * {@link Identifiable} does not require its implementations to be serializable, but {@link BaseEntity} and therefore all its subclasses are. + */ +class IdentifiableTest { + + @Test + void identifiableIsNotSerializable() { + assertFalse(Serializable.class.isAssignableFrom(Identifiable.class)); + } + + @Test + void baseEntityIsSerializable() throws Exception { + assertTrue(Serializable.class.isAssignableFrom(BaseEntity.class)); + + var person = new Person(); + person.setId(42L); + assertEquals(person, serializeAndDeserialize(person)); + } + +}