Repository navigation
Preserve sign words that do not introduce a number - #2902
Open
pandaxiong0729 wants to merge 1 commit into
Open
pandaxiong0729 wants to merge 1 commit into
pandaxiong0729 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English number normalization currently changes ordinary phrases such as
the positive and negative effectstothe +and negative effects, anda positive point of viewtoa +point of view. The sign handler accepts every parser keyword as the beginning of a number, includingand, currency names, andpointwithout a following value.Only consume a sign word when it introduces a number. Look ahead through
point,double, andtripleusing the same rules as their existing numeric handlers, so signed decimals and repeated digits keep working. Add regression and control cases for both English normalizers.Validation on Windows, Python 3.14.2 and PyTorch 2.15.0:
git diff --check: passed.pre-commit run --all-filescould not initialize its first hook because GitHub reset the connection while fetchingpre-commit-hooks. The matching pinned formatter/linter versions were run directly as listed above.Model transcription and the other Python versions in CI were not run. Prepared and tested with Codex assistance.