From 8edf87bc9d1062805d15028bcaef658b98cd9d23 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Thu, 8 Oct 2026 21:43:26 +0200 Subject: [PATCH] [test] Skip test on Node.js versions where it does not apply In Node.js versions >= 27.0.0-alpha.0.0.0 the HTTP client rejects the response before emitting the `'upgrade'` event. Refs: https://github.com/nodejs/node/commit/e5778f78 --- test/websocket.test.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/websocket.test.js b/test/websocket.test.js index 6f12dfacf..dfc35d8f1 100644 --- a/test/websocket.test.js +++ b/test/websocket.test.js @@ -984,7 +984,14 @@ describe('WebSocket', () => { beforeEach((done) => server.listen(0, done)); afterEach((done) => server.close(done)); - it('fails if the Upgrade header field value cannot be read', (done) => { + it('fails if the Upgrade header cannot be read', function (done) { + // + // In Node.js versions >= 27.0.0-alpha.0.0.0 the HTTP client rejects the + // response before emitting the `'upgrade'` event. See + // https://github.com/nodejs/node/commit/e5778f78. + // + if (process.versions.modules >= 153) return this.skip(); + server.once('upgrade', (req, socket) => { socket.on('end', socket.end); socket.write(