Repository navigation
fix (routeparams): correct count and array lengths in from_file - #220
Open
amansingh1207 wants to merge 1 commit into
Open
amansingh1207 wants to merge 1 commit into
amansingh1207 wants to merge 1 commit into
Conversation
from_file used count-1 instead of count-2 and left status/message unsliced, while fuel/power loops missed last segment. Fix round-trip and totals. Closes 52North#219
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue:
Fixes Issue #219
Changes:
from_file,get_full_fuel,get_fuel_per_dist,get_mean_powerFurther Details:
Summary:
Before: 4 points -> count 3, status 4 vs speed 3, fuel missed last segment (two off-by-ones cancelled for fuel). After: count 2, all Type1 len 3, fuel sums all segments.
Dependencies:
None
PR Checklist: