Repository navigation
fix (routeparams): fix __eq__ to use ship params - #222
Open
amansingh1207 wants to merge 1 commit into
Open
amansingh1207 wants to merge 1 commit into
amansingh1207 wants to merge 1 commit into
Conversation
RouteParams has no fuel/rpm attributes, use ship_params_per_step.fuel_rate/rpm for comparison. Closes 52North#221
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue:
Fixes Issue #221
Changes:
__eq__test_routeparams_eqFurther Details:
Summary:
Before:
a==braisedAttributeError: fuel. After: comparesship_params_per_step.fuel_rate/rpm, returns True.Dependencies:
None
PR Checklist: