Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DF-053: The Chinese
networkQualitydescription incorrectly suggests that any channel can report up to four remote users. State the confirmed CSD-62348 rule: remote quality feedback is enabled by default only while the channel has fewer than five broadcasters. At five or more broadcasters it is disabled; local quality still uses uid 0.Keep the shared Native DITA descriptions consistent across iOS, macOS, Android and Windows/C++. Do not change callback signatures or quality-score definitions. Regenerate the corresponding Chinese HTML with the repository's customized Oxygen transformation.
Validation results and related source PR are recorded in the DF-053 workbench. Production verification is pending publication.
XML parsing and
git diff --checkpassed. The four customized Oxygen scenarios completed successfully. Local browser inspection of the generated iOS page confirms the broadcaster threshold, uid=0 behavior and callback anchor. Exactly four generated description paragraphs changed. Historical Android connection-state drift was excluded. Generation retains existing DOTJ058E diagnostics and an unrelated Android checkAssetExists key warning.Source DITA: #4028
Chinese site: https://github.com/AgoraIO/shengwang-doc-source/pull/2137