Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unescaped attribute values in images_as_html output
With
images_as_html(orimages_with_sizewhen width/height is set), the<img>tag is rebuilt by concatenatingsrc,width,heightandaltinto single-quoted attributes. HTMLParser has already decoded character references by then, so<img src="x.jpg' onerror='alert(1)">, which is inert as input and passes an HTML sanitizer that allowsimg[src], comes out as<img src='x.jpg' onerror='alert(1)' />. Plain values likealt="Bob's photo"also produce broken markup. The values now go throughhtml.escapebefore being written, and a fixture covers the src/width/alt cases.