Repository navigation
Keep the previous game visible in the home tile row, with the name and state icon as on the console - #150
Open
Lenny4250gh wants to merge 10 commits into
Open
Keep the previous game visible in the home tile row, with the name and state icon as on the console#150Lenny4250gh wants to merge 10 commits into
Lenny4250gh wants to merge 10 commits into
Conversation
Add constants for tile peek shift and opacity in theme.
Updated the layout and styling of game tiles in the TileRow widget, including adjustments to the height, label positioning, and text properties.
Updated tile peek shift and opacity values for UI.
Updated the layout and structure of the game tile row, adjusting the positioning of labels and icons for better alignment and clarity.
12 tasks done
Author
|
waiting for updated-goldens to finish loading |
Author
|
@utkuhalis i uploaded the updated-goldens, try checking now |
Collaborator
|
Thanks a lot for this, Lenny. The previous tile peeking in from the edge is a nice touch, and the change is small and easy to follow. A few things before it can go in. Required changes
Nice to have
The Mac launcher gets the same change in its own PR, with the same numbers, so the two launchers stay alike. It lands together with this one. |
Author
|
@utkuhalis changes made. You can now regenerate the golden files in your repository including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the home screen, when the selected game is not the first one, the previous game used to fade out completely. It now stays on the left, almost at full brightness and partly past the window edge, so you can see where you came from.
The tile row is also closer to the real console home screen:
How
lib/ui/home.dart(TileRow):tilePeekOpacityinstead of fading to 0. The ones before it still fade out.tilePeekShiftto the right so the previous tile is mostly visible. On the first game it goes back to 0. The move uses the existingMotion.layoutanimation.StateLabelhas a newiconOnlyoption, used by the tile row. A plain locked game shows no icon there, since its tile already has the padlock. The hero and the games panel keep the full label.lib/ui/theme.dart: two new constants,tilePeekShift(48) andtilePeekOpacity(0.85), to tune the effect.Notes
tilePeekShiftto 0 keeps the alignment and shows a thinner strip of the previous tile.