Repository navigation
feat(hotkey): open the dashboard from the OMEN key - #27
Merged
Merged
Conversation
MANUAL (and BETTER_AUTO, which drives the fans through MANUAL) turns the firmware fan curve off and then writes fanN_target to set a speed. On boards that expose no target -- 8E5F / Victus 15-fb3xxx among them -- only the first half of that happens: pwm1_enable is set to 1, every fanN_target write fails, and the fans are left at whatever RPM they happened to be at with nothing managing cooling. Refuse that combination and stay on the firmware curve instead. AUTO and MAX are both driven by pwm1_enable alone, so they keep working; boards that do expose fanN_target are unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELZkKrF8iHGDQG3qK19xcG
HP Victus and Omen laptops have a dedicated OMEN key above the keyboard that did nothing on Linux. The hp-wmi driver already reports it on its "HP WMI hotkeys" input device as KEY_PROG2 (scancodes 0x21a5 and 0x21a8 both map to it), so all that was missing was something listening. victus-hotkeyd watches for that key and runs victus-control. It finds the device by name rather than by event number, which is not stable across reboots or DKMS rebuilds, and re-scans every 5s if the device disappears so a module reload does not require restarting the service. Presses are debounced, since the firmware sometimes reports one press twice. It ships as a *user* unit, not a system one: it launches a GUI, so it has to live in the session that owns the display. Reading the hotkey device is granted to the victus group by a udev rule, matching how the fan and backlight nodes are already handled. That device only carries the firmware hotkeys -- brightness, mic mute, OMEN -- never the typing keyboard, so this exposes no keystrokes; it is deliberately narrower than adding the user to the input group. The frontend becomes a GtkApplication so the process is a single instance. Without that, every press would stack up another dashboard; now a second press raises the window that is already open. The .desktop file gains a matching StartupWMClass so the shell still pairs the window with the launcher. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELZkKrF8iHGDQG3qK19xcG
Batuhan4
added a commit
that referenced
this pull request
Sep 24, 2026
#27 only wired victus-hotkeyd into the Ubuntu installer; meson already installs the binary, user unit and udev rule on every distro, so mirror the same enable step and input-subsystem trigger. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
|
Merged — thank you! The OMEN key listener and the fan-mode guard are both great additions, and the hardware test notes made review easy. I added a small follow-up that wires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The dedicated OMEN key above the keyboard did nothing on Linux. This makes it open the Victus Control dashboard.
The
hp-wmidriver already reports it — nothing was listening. Confirmed by reading the driver's own keymap overEVIOCGKEYCODE_V2rather than guessing:victus-hotkeydA small daemon that watches for
KEY_PROG2and runsvictus-control./dev/input/eventNis not stable across reboots or DKMS rebuilds.modprobe -r hp_wmiduring an install or a DKMS rebuild does not require restarting the service.It ships as a user unit rather than a system one, because it launches a GUI and has to live in the session that owns the display.
Permissions
99-victus-hotkey.rulesgrants the hotkey device to thevictusgroup, matching how the fan and backlight nodes are already handled.That device carries only the firmware hotkeys — brightness, mic mute, OMEN — and never the typing keyboard, so this exposes no keystrokes. It is deliberately narrower than adding the user to the
inputgroup, which would hand over every input device including the real keyboard.Single instance
The frontend becomes a
GtkApplication. Without it every press would stack up another dashboard; now a second press raises the window that is already open. The.desktopfile gains a matchingStartupWMClassso the shell still pairs the window with the launcher.Second commit: fan-mode guard
fix(fan): keep the firmware curve when the board exposes no fan targetis independent of the OMEN key and happy to be split into its own PR if you'd prefer.MANUAL(andBETTER_AUTO, which drives the fans throughMANUAL) turns the firmware curve off and then writesfanN_target. On a board with no target only the first half happens:pwm1_enablegoes to 1, every target write fails, and the fans are left wherever they were with nothing managing cooling.Observed on 8E5F / Victus 15-fb3xxx, where
hp-wmi/hwmon/hwmonN/exposes onlyfan1_input,fan2_input,pwm1_enable— no targets, with the patched module loaded. The backend logged this every few seconds:The guard refuses only that combination.
AUTOandMAXare driven bypwm1_enablealone and keep working; boards that do exposefanN_targetare unaffected.Hardware validation
Tested on HP Victus 15-fb3xxx (board 8E5F), Ubuntu 26.10, kernel 7.0.0-30, GTK4, single-zone keyboard.
KEY_PROG2viauinput"HP WMI hotkeys" went away, waiting for it to come backAUTO/MAXfan modespwm1_enable2 / 0MANUALon a board with no targetSET/GETround-trip OKmeson testBecause this board has no fan targets,
GET_FAN_TARGET_SUPPORTreportsUNSUPPORTEDand the UI already hides manual speed — so the guard is belt-and-braces for anything that calls the script directly.I don't have a four-zone Omen board to test against; the hotkey path is independent of zone count, but a second pair of eyes there would be welcome.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ELZkKrF8iHGDQG3qK19xcG