Repository navigation
Add host-quit, which closes Amiberry - #22
Merged
Merged
Conversation
Amiberry's WHDLoad booter ran the third-party AmiQuit when a game exits; host-quit replaces it with our own. It calls uaelib's ExitEmu through uae.resource and waits for Amiberry to close. The booter runs it on every machine, Kickstart 1.3 and the 68000 included, so it is plain 68000 code built without the C runtime: libnix needs utility.library for 32-bit arithmetic on a 68000, and Kickstart 1.3 has none. It has its own entry point, takes the AmigaDOS arguments from the registers and prints through dos.library calls Kickstart 1.2 has.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
host-quit: it closes Amiberry, as quitting from its menu does. It calls uaelib'sExitEmu(trap 13) throughuae.resource, then waits for Amiberry to close; Ctrl-C returns. It replaces the third-party AmiQuit that Amiberry's WHDLoad booter runs when a game exits; a follow-up Amiberry PR switches the booter over.-nostartfiles -nostdlib -ffreestanding). On a 68000, libnix does 32-bit arithmetic through utility.library, which Kickstart 1.3 doesn't have; a libnix build failed there with "utility.library failed to load".-fno-toplevel-reorder. It takes the AmigaDOS arguments from A0 and D0, and prints withOutput()/Write(), which Kickstart 1.2 has.?help, exit code 10 for an unexpected argument, 2 withoutuae.resource. It doesn't need Native Code, because only the host-command traps (88-95) do.P_InstallCommandTool) and.gitignore;$VERand guide entry);Verified:
S/Startup-SequencerunsDH0:C/host-quit.host-quit ?prints the help and returns 0;host-quit extraprints "Unexpected argument" and returns 10.sacredbanana/amiga-compiler:m68k-amigaos):make allandmake test-packagepass.make test-unitfails inhost-env's "temp directory should be removed" on unmodified master too, in this local Docker setup.@midwan