Repository navigation
Fix host-quit's entry point and release 2.8 - #24
Conversation
host-quit has no startup code, so AmigaDOS runs its first code byte. The release toolchain placed the "dos.library" string ahead of the entry function, and the 2.7 binary crashed when run. The file now opens with a branch to the entry point, whatever the compiler emits first, and the package check fails if host-quit's first code is not a branch.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5bc110c8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amiga version strings compare only version and revision, so the installer saw 2.7.1 as 2.7 and defaulted to keeping the broken host-quit in Expert mode.
midwan
changed the title
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Host-Tools 2.8 fixes
host-quitfrom the 2.7 package, which crashed when run.host-quithas no startup code, so AmigaDOS runs its first code byte. The toolchain the release workflow uses (sacredbanana/amiga-compiler) placed the"dos.library"string ahead of the entry function, so the 2.7 binary's first code bytes are64 6f("do"). My local gcc10 builds happened to put the function first, which is why testing didn't catch it.jra _start, kept first by-fno-toplevel-reorder. The first instruction is that branch whatever the compiler emits first.tests/test_package_layout.shfinds the firstHUNK_CODEand fails unless its first bytes are a branch (60xx) or ajmp(4ef9). It rejects the published 2.7 binary.version.mk, the guide's$VERand the changelog.It's 2.8 rather than 2.7.1 because Amiga version strings compare only version and revision. The installer (
P_CopyVersionedFile) would see 2.7.1 as 2.7 and, in Expert mode, default to skipping the fixedhost-quit.Verification
bra.s _start(6046); a gcc10 build starts withbra.w _start.make allandmake package(including the new check) pass.