Skip to content

ci: run the consumer smoke test on pull requests - #154

Merged
lmcorbalan merged 15 commits into
chore/release-artifactfrom
ci/pr-consumer-smoke
Aug 31, 2026
Merged

lmcorbalan merged 15 commits into
chore/release-artifactfrom
ci/pr-consumer-smoke

Conversation

@lmcorbalan

Copy link
Copy Markdown
Collaborator

Summary

Closes #147

The consumer smoke test ran only at release time, so a pull request could break standalone consumability of the DAR and stay green until a tag was already chosen.

Changes

  • Adds a Consumer smoke test step to ci.yml's daml job, after Test, gated on the job's existing scope gate with SKIP_BUILD=1.
  • Widens that gate to consumer-smoke/ and scripts/consumer-smoke.sh, without which a dropped --package line would scope out and stay green.
  • Corrects the sentences in CLAUDE.md, SPEC.md and scripts/consumer-smoke.sh that said nothing on the pull-request path runs it.

Acceptance criteria

  • All four from the issue are met. The fourth needed no code: Verify the SDK pins already sweeps consumer-smoke/consumer/daml.yaml.

Test plan

npm run build 0, npm test 80 ok, npm run smoke 0. Both halves of criterion 3 were driven red: removing a --package line fails on the hidden package, and naming a unit-id the DAR does not bundle fails with cannot satisfy --package. The gate was run against 15 paths in both directions.

Breaking changes

None. A pull request touching only consumer-smoke/ or the smoke script now installs the toolchain and builds, where it previously scoped out in seconds.

@lmcorbalan
lmcorbalan merged commit acadba1 into chore/release-artifact Aug 31, 2026
2 checks passed
@lmcorbalan
lmcorbalan deleted the ci/pr-consumer-smoke branch August 31, 2026 17:42
@github-project-automation github-project-automation Bot moved this from In review to Done in Canton - dAppBooster (#390) Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant