Repository navigation
[IMPROVEMENT] Test command line options through ccxr_parse_parameters into C - #2409
Open
Deepak-negi11 wants to merge 1 commit into
Open
Deepak-negi11 wants to merge 1 commit into
Deepak-negi11 wants to merge 1 commit into
Conversation
5 of 7 tasks
… into the C options
Deepak-negi11
force-pushed
the
test/cli-through-c
branch
from
October 24, 2026 23:04
573ba91 to
3651944
Compare
Deepak-negi11
changed the title
5 of 7 tasks
Collaborator
CCExtractor CI platform finished running the test files on windows. 171/237 tests matched the approved output:
66 tests do not match the approved output. That is the pass/fail verdict. Whether this branch caused it is a separate question, answered below.
Compared with the tip of master — test 9693, commit af4b28d:
Fail on both but produce different output — behaviour moved even though the verdict did not:
Fail there, pass here:
Compared with the commit this branch was cut from: the same run as the tip of master (test 9693), so the comparison above already covers it. This branch changes the behaviour of 42 test(s) relative to the tip of master. Those are the ones worth looking at; anything else in the list fails the same way on both sides. |
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
cd src/rust && cargo test --lib cli_testsTo see what the new tests catch, make one of these changes and run both test sets:
--uclato C (common.rs)test_ucla_reaches_cfails--no-fontcolorto Ctest_no_font_color_reaches_cfails--gui-mode-reportsto Ctest_gui_mode_reports_reaches_cfailsPart of #2408 (first step).
Problem
The parser tests check the Rust settings right after parsing. They never run the real entry point that converts old spellings, and they never look at what C receives. So bugs in those two places pass every test, like the ones fixed in #2367, #2370 and #2397.
What this adds
src/rust/src/cli_tests.rs:ccxr_parse_parameters, the same functionmain()calls, and returns copies of theccx_optionsandtlt_configthat C reads. (Incargo testno C code runs, so the tests check whatcopy_from_rustwrites for C.) It holds a lock because those are global.--delay,--out,--ucla,--608,--no-fontcolor,--gui-mode-reports,--startat,--sentencecap,--mkvlang,--tpage, plus an unknown option being rejected.Next steps (separate PRs): a test that fails when an option has no test, then tests for the options that have none yet.
Testing
cargo test(437 passed),cargo fmt --check,cargo clippy -- -D warnings.