Repository navigation
Use hostname for auth data and default max_execution_payment to 0 - #11303
Merged
StefanBratanov merged 6 commits intoSep 19, 2026
Merged
StefanBratanov merged 6 commits into
StefanBratanov merged 6 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
zilm13
reviewed
Sep 18, 2026
| paramLabel = "<uint64>", | ||
| showDefaultValue = CommandLine.Help.Visibility.ALWAYS, | ||
| description = | ||
| "The maximum execution layer payment (in Gwei) that counts when a builder's bid is valued", |
Contributor
There was a problem hiding this comment.
I'd highlight what 0 means here
| Arguments.of("https://user:pw@builder.example.com/", "builder.example.com"), | ||
| Arguments.of("https://10.0.0.5:18550/eth/v1/builder", "10.0.0.5"), | ||
| Arguments.of("https://[0:0:0:0:0:0:0:1]:8443/", "[::1]"), | ||
| Arguments.of("https://[2001:db8::192.0.2.1]/", "[2001:db8::c000:201]")); |
Contributor
There was a problem hiding this comment.
I'd add punycode example also
Contributor
Author
There was a problem hiding this comment.
Actually that was a good catch, it caused issues with the current code, all fixed
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a949b81. Configure here.
StefanBratanov
force-pushed
the
hostname_auth_data
branch
from
September 19, 2026 18:25
cb75483 to
075a1ce
Compare
StefanBratanov
enabled auto-merge (squash)
September 19, 2026 18:26
StefanBratanov
merged commit Sep 19, 2026
0ed1bfa
into
Consensys-Incorporated:master
93 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
As per ethereum/builder-specs#168, we need to use hostname for auth data, also defaulting
max_execution_paymentto 0 after a discussion with other clients, added CLI option to modify that.Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes builder bid authentication and default bid valuation semantics for Gloas proposers; misconfigured auth host normalization could break builder auth interoperability.
Overview
Aligns Gloas builder auth and bid valuation with updated builder-specs: builder request auth now signs normalized hostname bytes (lowercase ASCII, punycode IDN, RFC 5952 IPv6) instead of the full URL, with per-host caching in
BuilderConfigProvider.max_execution_paymentdefaults to 0 (trustless bid value only) instead of the removed spec constantUInt64.MAX_VALUE. Operators can set it via hidden CLI--Xbuilder-max-execution-payment, plumbed throughValidatorConfiginto eachBuilderEntry.--Xbuilder-urlsparsing rejects URLs without a valid host. Tests cover CLI wiring and auth-data normalization cases.Reviewed by Cursor Bugbot for commit 075a1ce. Bugbot is set up for automated code reviews on this repo. Configure here.