Repository navigation
test: 隔离巡检成功路径用例截止放宽到 10 秒 - #85
Merged
Merged
Conversation
16 个成功路径用例原先用 5 秒截止,低于生产默认的 8 秒; 高负载下冷启动隔离子进程即可超过 5 秒,偶发 OVERVIEW_TIMEOUT。 改用服务允许的上限 10 秒,生产代码不变。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
tests/test_console_inspection.py的IsolatedOverviewServiceTests在机器高负载时偶发OVERVIEW_TIMEOUT。原因:16 个成功路径用例把截止设成
timeout_seconds=5,比生产默认的 8 秒还短。这些用例要冷启动一个隔离的 Python 子进程(spawn),负载高时启动本身就会超过 5 秒。改动
_SUCCESS_TIMEOUT_SECONDS = 10,16 处timeout_seconds=5改为引用它。10 秒是IsolatedOverviewService允许的上限(0.1 到 10 秒)。验证
tests.test_console_inspection(人为制造负载),全部通过。ruff check src tests experiments通过。test_package_version_matches_pyproject,原因是本地开发环境里 dyro 的安装元数据还停在 0.7.18,和本改动无关,以 CI 的全新安装为准。影响
不影响已发布的包,不需要发新版本。