Skip to content

Stop a hung market request from leaving the table on its skeleton. #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manish-rorotechnology wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop a hung market request from leaving the table on its skeleton. #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions apps/web/components/markets/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,23 @@ interface MarketsPage {
coins: Coin[];
}

const REQUEST_TIMEOUT_MS = 15_000;

async function get<T>(path: string, signal?: AbortSignal): Promise<T> {
const response = await fetch(`${MARKET_API_URL}${path}`, { signal });
if (response.status === 404) throw new NotFoundError(path);
if (!response.ok) throw new Error(`Market API ${path} responded ${response.status}`);
return response.json() as Promise<T>;
const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), REQUEST_TIMEOUT_MS);
const onAbort = () => controller.abort();
signal?.addEventListener("abort", onAbort, { once: true });
if (signal?.aborted) controller.abort();
try {
const response = await fetch(`${MARKET_API_URL}${path}`, { signal: controller.signal });
if (response.status === 404) throw new NotFoundError(path);
if (!response.ok) throw new Error(`Market API ${path} responded ${response.status}`);
return response.json() as Promise<T>;
} finally {
clearTimeout(timeout);
signal?.removeEventListener("abort", onAbort);
}
}

export class NotFoundError extends Error {}
Expand Down
Loading