Skip to content

feat(workflow-executor): handle action approvals within workflows [PRD-29] - #2062

Draft
Scra3 wants to merge 2 commits into
mainfrom
feature/prd-29-handle-action-approvals-within-workflows
Draft

Scra3 wants to merge 2 commits into
mainfrom
feature/prd-29-handle-action-approvals-within-workflows

Conversation

@Scra3

@Scra3 Scra3 commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Feature branch

Integration branch for PRD-29, action approvals in workflows. Ticket PRs target this branch, milestone by milestone: M1 PRD-2004 and PRD-2005, M2 PRD-2013 and PRD-2006, M3 PRD-2014 and PRD-2015. It merges to main once, at the end: forestadmin-server, then agent-nodejs, then forestadmin.

Dev split and contract: https://linear.app/forestadmin/document/dev-split-action-approvals-in-workflows-f7e853db74be

Stays in draft until every ticket has landed.

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

🤖 Generated with Claude Code

Note

Handle action approvals within workflow-executor workflows

This PR contains only blank line changes. There are no functional changes to workflow action approvals.

Macroscope summarized 2e1ed9b. (Automatic summaries will resume when PR exits draft mode or review begins).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

PRD-29

…and resume on the reviewer's branch [PRD-2004] (#2063)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@qltysh

qltysh Bot commented Nov 5, 2026

Copy link
Copy Markdown

8 new issues

Tool Category Rule Count
qlty Structure Function with many returns (count = 4): toStepOutcome 4
qlty Structure Function with high complexity (count = 17): toUpdateStepRequest 4

@qltysh

qltysh Bot commented Nov 5, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 1.6%.

Modified Files with Diff Coverage (8)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/types/validated/execution.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/types/validated/step-outcome.ts100.0%
Coverage rating: A Coverage rating: A
...-executor/src/executors/trigger-record-action-step-executor.ts100.0%
Coverage rating: A Coverage rating: A
...workflow-executor/src/adapters/run-to-available-step-mapper.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/errors.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/types/validated/step-definition.ts100.0%
Coverage rating: A Coverage rating: A
...ow-executor/src/adapters/step-outcome-to-update-step-mapper.ts100.0%
Coverage rating: A Coverage rating: A
...ow-executor/src/executors/summary/step-execution-formatters.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants