Repository navigation
Conversation
Aligns with Android (stream-video-android#1859), iOS and JS. A caller whose coordinator WebSocket died silently now reads the ring state at 9/14/19/24/29 s of a 30 s ring rather than 15/20/25 s. A callee who takes longer than 9 s to answer now costs one read; `startAfter` can still be raised through `StreamVideoOptions.ringStatePolling`. Resolves FLU-998 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #1501 +/- ##
==========================================
+ Coverage 49.81% 50.69% +0.88%
==========================================
Files 461 465 +4
Lines 32149 32384 +235
==========================================
+ Hits 16015 16418 +403
+ Misses 16134 15966 -168 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Rene Floor <rene.floor@getstream.io>
SDK Size
Measured on |
Size BreakdownWhat each SDK adds to an empty release app, per Dart package and native library. Dart sizes are uncompressed symbol sizes. Open the This run does not measure ios. Measured on android ·
|
| Component | Size | Δ vs v2 |
|---|---|---|
native:libjingle_peerconnection_so.so |
11.96 MB | 0 |
package:stream_video |
1.06 MB | +0.0 KB |
classes.dex |
261.9 KB | 0 |
dart:@unknown |
254.8 KB | -0.0 KB |
dart:_http |
153.9 KB | 0 |
package:protobuf |
146.0 KB | 0 |
dart:mixin_deduplication |
137.3 KB | 0 |
native:libdartjni.so |
121.7 KB | 0 |
dart:io |
99.3 KB | +0.0 KB |
dart:async |
75.6 KB | 0 |
package:stream_core |
65.6 KB | 0 |
package:stream_webrtc_flutter |
56.3 KB | 0 |
package:rxdart |
54.3 KB | 0 |
dart:core |
52.1 KB | 0 |
package:dio |
52.0 KB | 0 |
| other (71) | 535.7 KB | 0 |
android · stream_video_flutter: 17.34 MB (0)
| Component | Size | Δ vs v2 |
|---|---|---|
native:libjingle_peerconnection_so.so |
11.96 MB | 0 |
package:stream_video |
1.12 MB | +0.0 KB |
package:flutter |
698.7 KB | 0 |
classes.dex |
454.8 KB | 0 |
dart:@unknown |
428.7 KB | -0.0 KB |
dart:mixin_deduplication |
356.3 KB | 0 |
package:stream_video_flutter |
200.7 KB | 0 |
dart:_http |
154.3 KB | 0 |
package:protobuf |
145.6 KB | 0 |
dart:io |
136.4 KB | 0 |
package:stream_core_flutter |
124.2 KB | 0 |
native:libdartjni.so |
121.7 KB | 0 |
assets |
118.5 KB | 0 |
package:hive_ce |
99.2 KB | 0 |
dart:@shared |
83.0 KB | 0 |
| other (98) | 1.22 MB | 0 |
Resolves FLU-998
Android parity with stream-video-android#1859. iOS (stream-video-swift#1357) and JS (stream-video-js#2492) made the same change.
What changes
RingStatePollingSettings.startAfternow defaults to 9 s instead of 15 s. The interval stays at 5 s. A caller whose coordinator WebSocket died without notice now reads the ring state at 9/14/19/24/29 s of a 30 s ring instead of 15/20/25 s.The cost: a callee who takes longer than 9 s to answer now costs one read even when the WebSocket is healthy. Integrators can still raise
startAfterthroughStreamVideoOptions.ringStatePolling. The doc comment explains this.Tests
call_ring_state_polling_test.dartruns on the default settings. Its time steps now come fromRingStatePollingSettings()instead of a hard-coded 15 s.ring_state_poller_test.dartsets its own timings on purpose, because its assertions count polls. Those timings are now 9 s, and the expected counts are recalculated.Changelog
Ring-state polling has not shipped in a release yet; it is listed under
## Upcoming (major). So this PR corrects that entry's "After 15 seconds" to 9 seconds and adds no separate entry.🤖 Generated with Claude Code