Repository navigation
Weather scenes, immersive view, and a transport clock fix - #6
Merged
Merged
Conversation
- Aurora on dark, clear, dry nights: three tilted curtains of green, blue and violet light with vertical rays, slowly swaying; fades with cloud, daylight and any precipitation. - Fog banks rolling along the hills on a WMO fog code, or as a light haze once cloud cover passes 75%. - Rain ripples spreading on the ground (more with heavier rain) and a soft, broken reflection of the sun or moon on the wet ground. - Pure, tested amounts in sky/sceneMath.ts; isFoggy() for WMO 45/48; "Fog" added to the Simulate weather types. Animations stop under prefers-reduced-motion.
Every parameter update called bpm.rampTo(tempo), even with the tempo unchanged. Tone ramps BPM exponentially, and its tick integration over an exponential ramp between two equal values is 0/0, so the transport clock computed NaN/-Infinity tick times and threw "Cannot read properties of undefined (reading 'time')" from TickSource.getTicksAtTime. Seen right after starting playback, almost always in Simulate mode where the hour (and so the tempo) doesn't move. Now the tempo only ramps when it actually changes (> 0.05 BPM), and linearly. Verified: no errors across repeated start/simulate runs, and tempo still ramps to the expected values (56 BPM at 3am, 95.3 at 2pm).
- New expand button in the tray: the tray and wordmark fade away, leaving the sky, the current chord and key in large type, and the place, weather and time beneath. - HorizonBand: a wide band of light along the horizon whose three additive ribbons rise and sway with the music's loudness and waveform (not rendered under prefers-reduced-motion). - Cursor and exit hint fade after 3 idle seconds. Click anywhere or press Escape to return; focus moves into the view on entry and back to its button on exit, and the hidden tray can't be tabbed to. Space still plays/stops. - Phones: the Rec button goes icon-only so the volume slider keeps room. - README updated for weather scenes and the immersive view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weather scenes
sky/sceneMath.ts). Simulate mode has a new "Fog" weather type to preview it.Immersive view
Bug fix: transport clock errors
Every parameter update re-applied the tempo with an exponential ramp, even when it hadn't changed. Tone's tick maths over an exponential ramp between two equal values is 0/0, so the clock computed NaN/-Infinity tick times and threw "Cannot read properties of undefined (reading 'time')" right after starting playback, almost always in Simulate mode. The tempo now only ramps when it actually changes, and linearly.
Testing