Skip to content

Fixing external tools with guestbook responses - #12801

Open
stevenwinship wants to merge 11 commits into
developfrom
12760-previewers-not-working-with-guestbook-responses
Open

stevenwinship wants to merge 11 commits into
developfrom
12760-previewers-not-working-with-guestbook-responses

add settings to config doc

e148396
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 29, 2026 in 1m 48s

Quality Gate failed

Annotations

Check warning on line 80 in src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "externalToolHandler1" local variable.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyjSG-Dfj-8j01LS&open=AaERyyjSG-Dfj-8j01LS&pullRequest=12801

Check failure on line 1267 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 90 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaFe5ixz3N-wMxDlS8jp&open=AaFe5ixz3N-wMxDlS8jp&pullRequest=12801

Check failure on line 2277 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaFe5ixz3N-wMxDlS8jq&open=AaFe5ixz3N-wMxDlS8jq&pullRequest=12801

Check warning on line 2294 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaFe5ixz3N-wMxDlS8js&open=AaFe5ixz3N-wMxDlS8js&pullRequest=12801

Check warning on line 3943 in src/test/java/edu/harvard/iq/dataverse/api/FilesIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 60 to less than 25.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyawG-Dfj-8j01LK&open=AaERyyawG-Dfj-8j01LK&pullRequest=12801

Check failure on line 523 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaGIMW-Pf_cmPQO_PRkC&open=AaGIMW-Pf_cmPQO_PRkC&pullRequest=12801

Check warning on line 2277 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "user".

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaFe5ixz3N-wMxDlS8jr&open=AaFe5ixz3N-wMxDlS8jr&pullRequest=12801

Check warning on line 62 in src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "externalToolHandler1" local variable.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyjSG-Dfj-8j01LR&open=AaERyyjSG-Dfj-8j01LR&pullRequest=12801

Check warning on line 101 in src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "externalToolHandler2".

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyjSG-Dfj-8j01LQ&open=AaERyyjSG-Dfj-8j01LQ&pullRequest=12801

Check warning on line 1267 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaFe5ixz3N-wMxDlS8jm&open=AaFe5ixz3N-wMxDlS8jm&pullRequest=12801

Check warning on line 62 in src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "externalToolHandler1".

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyjSG-Dfj-8j01LO&open=AaERyyjSG-Dfj-8j01LO&pullRequest=12801

Check warning on line 80 in src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "externalToolHandler1".

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyjSG-Dfj-8j01LP&open=AaERyyjSG-Dfj-8j01LP&pullRequest=12801

Check failure on line 506 in src/main/java/edu/harvard/iq/dataverse/FileDownloadServiceBean.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyl5G-Dfj-8j01LU&open=AaERyyl5G-Dfj-8j01LU&pullRequest=12801

Check warning on line 101 in src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "externalToolHandler2" local variable.

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AaERyyjSG-Dfj-8j01LT&open=AaERyyjSG-Dfj-8j01LT&pullRequest=12801