Skip to content

Accept BLS signing keys in key verification-key - #1502

Open
palas wants to merge 1 commit into
masterfrom
fix-bls-sig-key-in-ver-key-cmd
Open

palas wants to merge 1 commit into
masterfrom
fix-bls-sig-key-in-ver-key-cmd

Conversation

@palas

@palas palas commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Context

This PR addresses: #1501

key verification-key command was not accepting BLS signing keys.

This PR adds support for BLS signing keys to several functions that take signing keys

How to trust this PR

It is essentially extrapolation, except for tests, which now also apply to the dijkstra node key-gen-BLS command.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff
  • Changelog fragment added in .changes/

@palas palas self-assigned this Nov 12, 2026
Copilot AI balanced review requested due to automatic review settings November 12, 2026 18:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The BLS regression test defaults to text-envelope output, leaving the new Bech32 decoder path without round-trip coverage.

1 open issue
What changed in this PR

Addresses #1501 by extending the shared signing-key handling so key verification-key accepts BLS signing keys.

Changes:

  • Adds BLS support to text-envelope and Bech32 signing-key readers.
  • Generalizes the verification-key test helper and adds a BLS text-envelope round-trip test.
  • Adds a changelog entry documenting the supported input formats.
File Description
cardano-cli/​test/​cardano-cli-test/​Test/​Cli/​VerificationKey.hs Generalizes key-generation commands and adds the BLS regression test.
cardano-cli/​src/​Cardano/​CLI/​Type/​Key.hs Adds BLS signing-key handling and decoders for both formats.
.changes/​20261111_162405_cardano-cli_pablo.lamela_bls_verification_key.yml Documents BLS verification-key derivation support.

Review effort: Balanced

, FromSomeType (AsSigningKey AsStakePoolExtendedKey) AStakePoolExtendedSigningKey
, FromSomeType (AsSigningKey AsVrfKey) AVrfSigningKey
, FromSomeType (AsSigningKey AsKesKey) AKesSigningKey
, FromSomeType (AsSigningKey AsBlsKey) ABlsSigningKey

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG - cardano-cli 11.7.0.0 key verification-key function rejects bls signing key

2 participants