Repository navigation
Draw zero-radius SVG arcs as lines to their absolute end point - #2975
Closed
ozenyunus35 wants to merge 1 commit into
Closed
ozenyunus35 wants to merge 1 commit into
ozenyunus35 wants to merge 1 commit into
Conversation
Author
|
Sorry, I opened this as a draft by mistake, and GitHub doesn't let me mark it as ready for review. Could you switch it to ready? It's ready to be reviewed. |
Member
|
There is a limit of 1pr opened per user. Also there are guidelines. I'm sure you're able to read that 5 bullet points all by yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2974.
When an arc has
rxorryequal to 0, the path code replaces it with a line to the arc's end point. That end point is already absolute at this point (it's converted forajust above), but the replacement used the relativelcommand, so the line was drawn to the wrong place. It now usesL.Added
test_path_a_zero_radius: a rectangle drawn with two zero-radius arcs (one withrx = ry = 0, one with onlyrx = 0). It fails without the fix and passes with it.tests/draw/svg/test_paths.pypasses.I used an AI assistant to help draft parts of the code and tests; I reviewed the changes and ran the tests myself.