Repository navigation
Conversation
The build-nodejs job (and transitively deploy-nodejs) depended on build-extension, a workaround from 3e3352b (May 2026) when LBUG_EXTENSION_VERSION 0.17.0 wasn't yet published to the remote extension repo, so Node.js tests served locally-built extensions over a loopback HTTP server. The current extension version (0.22.0) is available on https://extension.ladybugdb.com, so plain INSTALL JSON in the Node.js tests resolves remotely. The workflow already exercised this path on every manual dispatch with the default skipExtensions=true (useBuiltExtensions=false), so the local-server machinery is dead weight. Drop the needs edge, the useBuiltExtensions input, and the local extension-server test steps.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit
In
build-and-deploy.yml,build-nodejshadneeds: [build-precompiled-bin, build-linux-builder-image, build-extension], which transitively gateddeploy-nodejs(needsbuild-nodejs) on extensions being built.The edge dates to 3e3352b (
ci: fix nodejs test failures, May 2026):LBUG_EXTENSION_VERSIONhad just been bumped to 0.17.0 before that version was published to the remote extension repo, soINSTALL JSONin the Node.js tests failed. The fix served locally-built extensions from a loopback HTTP server (useBuiltExtensionsinput + local server steps innodejs-workflow.yml).Why it is no longer necessary
https://extension.ladybugdb.com/v0.22.0/.../json/libjson.lbug_extension), so plainINSTALL JSONresolves remotely.skipExtensions=true(useBuiltExtensions=false), so the local-server workaround is exercised as unnecessary in practice.nodejs-workflow.ymlis only called frombuild-and-deploy.yml, so itsuseBuiltExtensionsinput has no other consumers.Change
build-and-deploy.yml: dropbuild-extensionfrombuild-nodejsneeds, drop theneeds.build-extension.resultclause from itsif, drop theuseBuiltExtensionspassthrough.deploy-nodejsis now decoupled from extension builds.nodejs-workflow.yml: remove the now-unuseduseBuiltExtensionsinputs and the four gated steps (download extensions artifact, start local repo server on Linux/macOS and Windows,sedrewrite oftest_data_type.js).The standalone
build-extensionjob and theskipExtensionsinput are untouched; extension builds still run independently.