Repository navigation
Merge to master - #177
Merged
Merged
Merge to master#177
Conversation
[auto-update] Update Ragger snapshots
Reject INS_MANAGE_SEEDWORDS when P2 exceeds WORDS_MAX_LENGTH or when 24*P2 overflows MONERO_IO_BUFFER_LENGTH. Without this check, an attacker-controlled P2 is used as both loop bound and stride into io_buffer, enabling out-of-bounds reads/writes that corrupt adjacent transaction state, keys, and UI buffers. Made-with: Cursor
- INS_OPEN_TX now rejects any P1/P2 other than P1=1,P2=0, preventing attacker-controlled values from propagating into tx_state_p1/p2 via update_protocol() and skipping the validation/UI flow. - MLSAG and CLSAG guards are split into separate protocol and state checks so that the state requirement (INS_VALIDATE or same signing family) is always enforced regardless of protocol version. Made-with: Cursor
Track whether the device-computed transaction prehash (mlsagH) appears in the CLSAG hash stream and reject at finalization if it was absent. Unlike MLSAG where the prehash is the first element and can be injected directly, CLSAG places the message at position 2n+2 in the c_to_hash vector (after ring keys and commitments), so a presence check across all chunks is used instead. This ensures a malicious host cannot substitute the approved transaction with a different CLSAG signature transcript. Made-with: Cursor
… backup display (by removing the whole functionality - it's not used by SW Wallets and never ported on large screen devices)
…tion prehash without user review
… in monero_blind.c
…ion signing handlers
- CLSAG/MLSAG preparation multiplies secret scalars by untrusted points without subgroup checks - Small-subgroup point accepted in monero_ecmul_k leaks internal view key bits via INS_SECRET_SCAL_MUL_KEY
Prevkey generation update
Fix some security issues
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from monero_client.crypto.hmac import hmac_sha256 | ||
| from monero_client.utils.varint import encode_varint | ||
| from monero_client.utils.utils import get_nano_review_instructions | ||
| from monero_client.exception import SecurityChangeAddress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan-build issues will be fixed on the SDK side: LedgerHQ/ledger-secure-sdk#1579