Skip to content

Fix typos in docstrings, comments, and error message - #292

Merged
cedelavergne-ledger merged 1 commit into
LedgerHQ:masterfrom
ronkagansky:fix/typos-and-docstrings
Oct 5, 2026
Merged

cedelavergne-ledger merged 1 commit into
LedgerHQ:masterfrom
ronkagansky:fix/typos-and-docstrings

Conversation

@ronkagansky

Copy link
Copy Markdown

Summary

  • Fix missing closing quote in f-string error message (misc.py:199)
  • Fix "provider" → "provided" in two docstrings (interface.py:505,528)
  • Fix "does not contains" → "does not contain" in docstring (interface.py:528)
  • Fix "popipng" → "popping" in comment (speculos.py:383)
  • Fix doubled word "a a" → "a" in comment (base_conftest.py:457)

The misc.py fix also corrects a minor display bug where the error message renders as App 'MyApp is not present instead of App 'MyApp' is not present.

- Fix missing closing quote in f-string error message (misc.py)
- Fix "provider" -> "provided" in docstrings (interface.py)
- Fix "does not contains" -> "does not contain" (interface.py)
- Fix "popipng" -> "popping" in comment (speculos.py)
- Fix doubled word "a a" -> "a" in comment (base_conftest.py)
@ronkagansky
ronkagansky requested a review from a team as a code owner October 4, 2026 20:32
@ronkagansky
ronkagansky requested review from agrojean-ledger and removed request for a team October 4, 2026 20:32
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@cedelavergne-ledger

Copy link
Copy Markdown
Contributor

Thank you @ronkagansky for your contribution 😉

@cedelavergne-ledger
cedelavergne-ledger merged commit c701e4a into LedgerHQ:master Oct 5, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants