Repository navigation
Conversation
n3ps
added a commit
that referenced
this pull request
Sep 12, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
3 of 7 tasks
Stop inventing convert activity rows with source/destination token pairs for mUSD conversion orchestration txs. Classify them as ordinary ERC-20 sends and defer accurate activity data to the indexed API. Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
cursor
Bot
force-pushed
the
n3ps/fix-musd-conversion-not-convert
branch
from
November 5, 2026 01:19
4ee9a69 to
c5b499f
Compare
n3ps
marked this pull request as ready for review
November 5, 2026 01:47
n3ps
enabled auto-merge
November 5, 2026 01:49
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionType.musdConversionthrough the existing ERC-20 transfer (send) path inlocal-transaction-mapperconvertcase that parsed calldata and inventedsourceToken/destinationTokenpairsCompanion to MetaMask/metamask-extension#46254, which removes convert UI treatment and excludes
musdConversionfrom local activity until the indexed API is authoritative.Test plan
yarn test:verbose --testPathPatterns=local-transaction-mapper.test.ts --coverage=falseinpackages/client-utils(80 passed)Made with Cursor
Note
Medium Risk
Changes the activity item type and data shape for mUSD conversion transactions, which can affect any client still expecting
convertuntil coordinated with the companion extension change.Reviewed by Cursor Bugbot for commit c5b499f. Bugbot is set up for automated code reviews on this repo. Configure here.