Repository navigation
Document the date contact property type and the segment date ops - #14
Merged
Merged
Conversation
- ContactProperties' docblock and the README's Contact properties section name the third type, date (a MillionSend extension), and what reads as a date: YYYY-MM-DD as midnight UTC, a date-time with T or a space (UTC when it names no zone), or Unix time in seconds or milliseconds between 2000-01-01 and 2100-01-01. A value or fallback_value that doesn't answers 422 validation_error, and contacts->get() returns a date's stored text. - The Segments section names the date ops on created_at and property:<key>: before and after take an ISO date or date-time, in_last_days and not_in_last_days a whole number of days from '1' to '36500'. - The Resend compatibility notes list the date type among the extensions. The param shape keeps type: string and responses stay plain arrays, so nothing changes at runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MillionSend v0.22.0 adds a third contact property type,
date, next tostringandnumber. It is a MillionSend extension, since Resend has only the two. This brings the docs in line; no code changes.ContactPropertiesdocblock and README → Contact properties: the type isstring,numberordate. A date property's values and itsfallback_valuemust read as a date, or the write answers422 validation_error. What reads as a date:YYYY-MM-DD, read as midnight UTC;Tor a space, read as UTC when it names no zone;contacts->get()returns each property as['type' => …, 'value' => …], with a date's stored text as its value, and adds acreate()example with'type' => 'date'.created_atandproperty:<key>take four date ops.beforeandaftertake an ISO date or date-time.in_last_daysandnot_in_last_daystake a whole number of days as a string, from'1'to'36500'.datetype is listed among the MillionSend extensions.Runtime behavior doesn't change.
create()'s param shape typestypeasstring, and responses arejson_decode(…, true)arrays, so a"type": "date"reads like any other. It's docs only, so there's no version bump and nothing to tag.Checked in
php:8.4-clithe way CI does:composer install, Pest (94 passed, 2 E2E skipped), Pint and PHPStan level 8 (no errors).🤖 Generated with Claude Code