Repository navigation
Conversation
jcpitre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web service CI fails on pull requests from forks, because GitHub does not give secrets to forks and the GCP login step needs one (example: MobilityData/gtfs-validator#2178).
What the job used to do
On every PR that changed
web/service/**, it logged in to Google Cloud and ranwebTestandwebBuild. Both start withwebSecrets, which downloads three files from Secret Manager (a credentials JSON, a New Relic license andapplication.properties), and then run the service tests and the build.Why it can stop running on PRs
What it does is covered by other workflows: test_pack_doc.yml runs the tests and packaging without credentials on every PR, and the staging deploy workflow runs the same secret-fetching build after each merge to master.
Downside: the staging workflow runs after the merge, so a problem with fetching secrets or deploying would now show up on staging instead of on the PR.
Change
The job is now manual-only (workflow_dispatch), so it no longer fails on fork PRs, and a maintainer can still run it from the Actions tab on a branch of this repository.