[achirkin]

NVIDIA/raft#3158 added 18 new instantiations of select-k kernels and this grows the cuvs binary size by 6 MB

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: NVIDIA/cuvs
• Branch: main
• File: .coderabbit.yaml
• Commit: 3dd62c1
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: f5d5bdbc-1779-4bcb-aef0-b289478a9576

📥 Commits

Reviewing files that changed from the base of the PR and between 3dd62c1 and 87db721.

📒 Files selected for processing: 1

• ci/validate_wheel.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Chores
  • Increased the maximum allowed wheel package size for Python libcuvs builds.

The wheel validation script raises the compressed-size limits for python/libcuvs: from 390Mi to 396Mi for CUDA 12, and from 239Mi to 245Mi for other CUDA versions.

Changes: Wheel validation

Layer / File(s)	Summary
Raise compressed-size limits ci/validate_wheel.sh	The script increases the python/libcuvs compressed-size limits for CUDA 12 and other CUDA versions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: improvement

Merge Risk: ⚪ Minimal · up to 87db7

No actionable merge-blocking risk remains in this threshold-only change.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the main change: increasing the wheel-size limit to accommodate the binary growth from raft #3158. The spelling error does not prevent understanding.
Description check		The description directly explains the cause of the wheel-size increase and identifies the reported binary growth from NVIDIA/raft#3158.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[jameslamb]

Fine for now, but effort to reduce this would be welcome. 245Mi compressed is still large enough to cause problems for users.

[jameslamb]

/merge