Repository navigation
Conversation
Signed-off-by: James Robb <47126579+jamesrweb@users.noreply.github.com>
Signed-off-by: James Robb <47126579+jamesrweb@users.noreply.github.com>
|
Coverage report for commit: 7c8c964 Summary - Lines: 100.00% ⏹️ | Methods: 100.00% ⏹️ | Branches: 100.00% ⏹️
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||
Signed-off-by: James Robb <47126579+jamesrweb@users.noreply.github.com>
Signed-off-by: James Robb <47126579+jamesrweb@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes N / A
PR Type
Description
Replaces Prettier and ESLint with Biome as the sole formatter and linter, aligning
this repository with the organisation-wide standard. A root
biome.jsonnowcarries the shared rules (2-space indent, double quotes, semicolons,
proseWrap: "always",organizeImportson, linterrecommendedpreset plususeBlockStatements: "error"), with"$schema"pointing at./node_modules/@biomejs/biome/configuration_schema.jsonso it always tracksthe installed Biome version. Biome's linter also surfaced real issues in the demo
app and tests that ESLint never covered, fixed in the same change. A follow-up
commit refreshes dev dependencies via
npm-check-updatesand regenerates thelock file, keeping
typescripton the latest 6.x.x exact pin.Proposed Changes
biome.json(org base rules, version-tracking$schema)package.json:formatis nowbiome check --write .,lintisbiome check .; removedformat:check,lint:fix, and theprettierhelper script;
integrateis nowpnpm lint && pnpm test && pnpm buildprettier,@trivago/prettier-plugin-sort-imports, the React ESLintplugins, and the rest of the ESLint toolchain from devDependencies; add
@biomejs/biome@2.6.4config/prettier/andconfig/eslint/eslint-plugin-react>eslintpeerallowedVersionsrule from
pnpm-workspace.yamlformatjob now runspnpm lintAGENTS.mdandREADME.md(commands tables, formatting/lintingsections, file tree, typescript pin note)
demo/app.jsx: removed unusedReact/useMemoimports (sketch listhoisted to module scope), removed spurious
useCallbackdependencies,added
type="button"to all buttonssrc/components/P5CanvasWithSketch.tsx: dropped refs from theuseEffectdependency array (useExhaustiveDependencies)tests/components/P5Canvas.test.tsx: hoistedErrorChildto module level(
noComponentHookFactories)ncu -uplus lock file regeneration —vitestand@vitest/coverage-v8moved to^5.0.5(vitest-canvas-mock@1.2.0supportsvitest 5 and the suite passes);
typescriptheld at6.0.3;packageManagerbumped to
pnpm@12.16.1How Has This Been Tested?
Ran the full local pipeline:
pnpm format,pnpm lint(exit 0, no warnings),pnpm test(22 passed, 2 pre-existing skips),pnpm build(exit 0, componentand demo builds).
Screenshots/Recordings
Breaking Changes
Checklist
Additional Notes
No public API changes — everything exported from
src/main.tsxis untouched.Biome's reformatting of source files is the expected formatting migration, not
a behavioural change. The two
it.skip-ped suspense tests remain skipped asbefore.