Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openmrs/openmrs-module-htmlformentry/pull/349 made a fix to
<obs style="checkbox" dateLabel="blah">element to only show the date label and date field for the obs when the checkbox is checked. This conflicts with the customsetUpObsWithObsDateTimefunction here, which has its own logic to hide the date label and date field. This PR takes that stuff out, and only keeps the logic to limit the date field'smaxDateto current date.I confirmed that the
setUpObsWithObsDateTimefunction is only in this repo, and is only used for the#syph-checkboxobs element.Testing done:
In patient's visit dash, opened PMTCT-followup.xml form (in ENTER mode), which immediately saves. Reopen form in EDIT mode to verify that, when the checkbox is not checked, the date label and field are not shown:
After checking the box, entering a date and save, reopen and form and confirm that the date label and field are shown and populated with the entered value:
