Skip to content

fix leaked api key check + crash on cdn proxy paths - #306

Merged
pxseu merged 2 commits into
Phineas:mainfrom
itztrmin:main
Jul 25, 2026
Merged

pxseu merged 2 commits into
Phineas:mainfrom
itztrmin:main

Conversation

@itztrmin

Copy link
Copy Markdown
Contributor

.set command was only checking if the key name matched a leaked api key, not the value. so if someone did .set token lnyd_abc123... it would be stored as a plaintext kv value instead of triggering the rotation flow. now it checks both key and value.
cdn avatar proxy would hard crash with a MatchError on any path with more than one dot (like /123.456.png), since it assumed the path always splits into two segments. now it just 404s instead of crashing.
nothing changes outside these two spots

@lostf1sh

Copy link
Copy Markdown
Contributor

LGTM

@pxseu

pxseu commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

as always, a good recommendation, you should not be using main as the source for PR.

moving forward please install elixir expert or a formatter, as your pull requests keep re-formatting the final line of the code.

@pxseu
pxseu merged commit 09d0e6f into Phineas:main Jul 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants