Repository navigation
fix leaked api key check + crash on cdn proxy paths - #306
Merged
Merged
Conversation
Contributor
|
LGTM |
Collaborator
|
as always, a good recommendation, you should not be using main as the source for PR. moving forward please install elixir expert or a formatter, as your pull requests keep re-formatting the final line of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.set command was only checking if the key name matched a leaked api key, not the value. so if someone did .set token lnyd_abc123... it would be stored as a plaintext kv value instead of triggering the rotation flow. now it checks both key and value.
cdn avatar proxy would hard crash with a
MatchErroron any path with more than one dot (like /123.456.png), since it assumed the path always splits into two segments. now it just 404s instead of crashing.nothing changes outside these two spots