Repository navigation
fix(e2e): bound the sidecar leg's av to <17 (faster-whisper kwarg) - #542
Merged
Merged
Conversation
The e2e-sidecar job installs its CPU runtime deps UNPINNED, so bare av resolved to 17.x even after the lock moved to 16.1.0 -- this leg never read the lock. faster-whisper 1.2.1 calls av.open(..., metadata_errors=...), removed in PyAV 17, so TRANSCRIBE died with the same TypeError the lock fix was for (nightly 2026-11-03..13 + the post-#537 dispatch). Bound "av>=14,<17" here, mirroring sidecar/pyproject.toml's constraint; lift both together when faster-whisper ships an av-17-compatible release. owner-directed automation; --admin documented
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e-sidecar job installs its CPU runtime deps UNPINNED, so bare
avresolved to 17.x even after #537 moved the lock to 16.1.0 — this leg never read the lock. faster-whisper 1.2.1 callsav.open(..., metadata_errors=...), removed in PyAV 17, so TRANSCRIBE died with the same TypeError the lock fix was for (nightly 2026-11-03..13 + the post-#537 dispatch, run 43496443584). Bound"av>=14,<17"here, mirroring sidecar/pyproject.toml's new constraint; lift both together when faster-whisper ships an av-17-compatible release.owner-directed automation; --admin documented