Repository navigation
Fix array $before/$after handling in $insert - #4179
Open
akhilbharati244 wants to merge 2 commits into
Open
akhilbharati244 wants to merge 2 commits into
akhilbharati244 wants to merge 2 commits into
Conversation
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4173.
The array form of
$beforeand$afterin$insertcould throw a TypeError when the referenced token did not already have an entry inlang[all].The array implementation now initializes the anchor object before assigning the token, consistent with the existing scalar implementation.
Changes
$insert.$beforewith an array of token names.$insert.$afterwith an array of token names.Testing
The regression test covers both array
$beforeand array$afterbehavior.