Skip to content

fix: resolve collection rewriter nullability warnings - #64

Merged
ycherkes merged 1 commit into
mainfrom
fix/collection-rewriter-nullability
Nov 6, 2026
Merged

ycherkes merged 1 commit into
mainfrom
fix/collection-rewriter-nullability

Conversation

@ycherkes

@ycherkes ycherkes commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

The collection-expression rewriter passed nullable visitor results into required expression operands, producing CS8600, CS8631, and CS8604 warnings in both Roslyn builds. Fall back to the original operand when a visit returns null for null-coalescing operands and collection assignment targets, matching the existing null-conditional rewriter pattern.

Validation:

  • Clean Release solution rebuild passed with no warnings in source/SyntaxRewriters/ (16 warnings eliminated across both Roslyn builds). The remaining 43 warnings are in generated integration-test sources.
  • All 224 solution tests passed, with no failures or skips.
  • git diff --check passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T20:14:27.998795Z 696144c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ycherkes
ycherkes merged commit d7f4280 into main Nov 6, 2026
1 check passed
@ycherkes
ycherkes deleted the fix/collection-rewriter-nullability branch November 6, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant