[ggazzo]

Proposed changes

First migration step of the "Fuselage components take no styling props" proposal (#42974): the app stops passing rcx-* props to Fuselage components.

• rcx-swiper-zoom-out/rcx-swiper-zoom-in (ImageGallery), rcx-sidebar-item__menu (SidepanelItem) and rcx-button--loading (RetryButton) match no CSS rule and no e2e locator: removed. SidebarItemMenu already puts rcx-sidebar-item__menu on the wrapper it renders.
• rcx-field-group__item on CustomFieldsForm's Field is still needed: FieldGroup patches the class onto CustomField, which doesn't forward it. It becomes a className (Box merges both into the same class list, so the output is identical).

node packages/fuselage/scripts/scan-style-props.mjs (from #42974) reports no rcx-* prop outside Fuselage after this change. The 20 sites inside Fuselage belong to the proposal's "Fuselage's own compositions" step.

Issue(s)

https://rocketchat.atlassian.net/browse/ARCH-2583

Steps to test or reproduce

No visual change expected: image gallery toolbar, sidepanel item kebab, outbound message retry button, custom fields in registration/omnichannel forms.

Further comments

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is still a draft
• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: db5ef81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.40%. Comparing base (1034e1f) to head (db5ef81).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #43024      +/-   ##
===========================================
+ Coverage    71.39%   71.40%   +0.01%     
===========================================
  Files         5281     5281              
  Lines       227560   227558       -2     
  Branches     42151    42087      -64     
===========================================
+ Hits        162457   162483      +26     
+ Misses       59867    59849      -18     
+ Partials      5236     5226      -10     

Flag	Coverage Δ
e2e	58.89% <100.00%> (-0.01%)	⬇️
e2e-api	49.27% <ø> (+0.24%)	⬆️
unit	71.46% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ggazzo]

Folded into #42974 as its own commit (3e1d113): the migration lives in one pull request, one commit per step.