Skip to content

[STORY-4481] feat(organizations): Type the current membership ID - #651

Open
annabelle-scalingo wants to merge 2 commits into
STORY-4480/feat/organizations-adminsfrom
STORY-4481/feat/membership-id
Open

annabelle-scalingo wants to merge 2 commits into
STORY-4480/feat/organizations-adminsfrom
STORY-4481/feat/membership-id

Conversation

@annabelle-scalingo

@annabelle-scalingo annabelle-scalingo commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

add member_id on the organizations returned by all()

Organizations returned by all() can carry membership_id, the ID of the
requester's own active membership — the ID expected by destroyMember().
Optional on the shared Organization model since show/create/update do
not return it. No semantic change to role/admins or with_admins.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@notion-workspace

Copy link
Copy Markdown

Organization.member_id is the ID of the current user's member record in
the organization, returned by all() and expected by destroyMember().
Optional on the shared Organization model since show/create/update do
not return it. No alias, no new method, no version change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@annabelle-scalingo
annabelle-scalingo marked this pull request as ready for review November 13, 2026 16:30

@baptmaury baptmaury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants