Repository navigation
fix(browser): stop waiting for full page load - #1539
Open
yazhou-qian wants to merge 1 commit into
Open
yazhou-qian wants to merge 1 commit into
yazhou-qian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadevent within Playwright's 30-second navigation timeoutRationale
The Browser provider only needs the IdP document to start loading before it can wait for the SAML POST to AWS. Waiting for every page resource to finish is unnecessary and can close an otherwise usable login page before the user can authenticate. The
commitstate still verifies that navigation received a response while allowing the existing SAML request listener to continue waiting.Testing
go test ./pkg/provider/browser -run 'TestNavigateToLoginPageWaitsForCommit|TestSigninRegex|TestExpectRequestOptions' -count=1go test ./cmd/saml2aws/commands -count=1go vet ./pkg/provider/browsermasterbranch and completed an end-to-end Browser provider SAML login that previously failed withFrame.Goto ... Timeout 30000ms exceeded