Repository navigation
Conversation
Psalm's taint analysis can only follow untrusted data through this library if its docblocks say which parameters are sinks and which return values are sources. These annotations are docblock-only and have no effect at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Psalm taint analysis annotations, so that Psalm follows untrusted data through php-imap in the projects that use it:
Messagegetters,Attributevalues) are untrusted input, as their sender chose them.Attachment::getContent()andgetName()are also input, but they are@methodmagic methods, which Psalm can't annotate with taints, so they are left to Psalm's stub.These are docblock-only changes, with no effect at runtime or on other tools. Psalm currently ships them as a stub for this library (vimeo/psalm#12467); having them here keeps them in step with the code.