Skip to content

GROOVY-12459: Failed AsyncChannel producer never closes the channel so for await hangs and the exception is dropped - #2987

Open
daniellansun wants to merge 2 commits into
masterfrom
GROOVY-12459
Open

daniellansun wants to merge 2 commits into
masterfrom
GROOVY-12459

GROOVY-12459: Return boolean from close(Throwable) and fail merge on …

25e9000
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 20, 2026 in 2m 0s

Annotations

Check failure on line 377 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFar7ajQHpmo8IG0QZL&open=AaFar7ajQHpmo8IG0QZL&pullRequest=2987

Check warning on line 260 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFPM5bR486RX33i1FR6&open=AaFPM5bR486RX33i1FR6&pullRequest=2987

Check warning on line 382 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFar7ajQHpmo8IG0QZK&open=AaFar7ajQHpmo8IG0QZK&pullRequest=2987

Check warning on line 262 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFPM5bR486RX33i1FR5&open=AaFPM5bR486RX33i1FR5&pullRequest=2987

Check warning on line 270 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFPM5bR486RX33i1FR7&open=AaFPM5bR486RX33i1FR7&pullRequest=2987

Check warning on line 407 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFar7ajQHpmo8IG0QZM&open=AaFar7ajQHpmo8IG0QZM&pullRequest=2987

Check warning on line 395 in src/main/java/groovy/concurrent/AsyncChannel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method.

See more on https://sonarcloud.io/project/issues?id=apache_groovy&issues=AaFar7ajQHpmo8IG0QZJ&open=AaFar7ajQHpmo8IG0QZJ&pullRequest=2987