Repository navigation
Remove the maven-shared-utils dependency - #1439
Merged
Merged
Conversation
JavadocUtil now uses DirectoryScanner and FileUtils from plexus-utils, which the plugin already declares. Part of apache/maven-shared-utils#452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavadocUtilnow usesDirectoryScannerandFileUtilsfrom plexus-utils, which the plugin already declares, instead of the maven-shared-utils copies, and the maven-shared-utils dependency is gone. The replaced methods have the same signatures and, with two exceptions, the same semantics. The default excludes applied when copying doc-files differ: plexus-utils also excludes**/RCS,**/SCCS,**/vssver.sccand**/project.pj, and no longer excludes**/.cvsignore. And when a resources directory cannot be listed (File.listFiles()returns null), the shared-utilscopyDirectoryStructureskipped it silently, while the plexus-utils one fails, today with aNullPointerException; codehaus-plexus/plexus-utils#349 makes that anIOExceptionnaming the directory.Verified:
mvn -B verify→ 82 of 83 unit tests pass (9 skipped);JavadocReportTest.testJavadocResourcesWithExcludesfails on this machine onmastertoo, before and after the change, so it is not caused here. The integration tests were not run.Part of apache/maven-shared-utils#452.