Repository navigation
Add make style targets for Ruby - #4026
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new recipes bypass the configured Bundler executable and fail when it is outside PATH.
1 open issue
What changed in this PR
Connects Ruby formatting to the existing make style workflow.
Changes:
- Adds
style-localhooks running RuboCop safe autocorrection. - Reuses the library configuration for tests and tutorials, and the library bundle for tutorials.
| File | Description |
|---|---|
| tutorial/rb/Makefile.am | Runs tutorial formatting through the library bundle. |
| test/rb/Makefile.am | Formats tests using the shared RuboCop configuration. |
| lib/rb/Makefile.am | Adds library formatting with rubocop -a. |
Review effort: Balanced
Client: rb Run RuboCop safe autocorrection for the Ruby library, cross-language tests, and tutorial through the existing Autotools style hooks. Co-Authored-By: OpenAI Codex (gpt-6.1-sol) <codex@openai.com>
kpumuk
force-pushed
the
rb-style-targets
branch
from
October 20, 2026 00:31
13fbfa7 to
ad57667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The Ruby Makefiles currently let
make stylefinish without running RuboCop. Addstyle-localhooks inlib/rb,test/rb, andtutorial/rbthat run safe autocorrection withrubocop -a. The test and tutorial targets use the shared library configuration; the tutorial uses the library bundle because it has no Gemfile.This follows Jens's clarification in #3367:
With Autotools already configured and the Ruby bundles installed, for example: