Repository navigation
[ZEPPELIN-6583] Use selected field for scatter point sizes - #5601
Merged
Merged
Conversation
voidmatcha
approved these changes
Nov 1, 2026
Member
|
Merged into master (3f3463b). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The Angular UI saves the selected scatter-chart Size column, but the renderer binds point sizes to the normalized Y values instead. Selecting a different Size column therefore does not change the size mapping.
This PR binds point sizes to the selected column and restores the default point size when the selection is cleared. It preserves the existing Y-value tooltips and group legend rather than allowing G2 to replace tooltip values or add a Size legend.
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
Run the focused regression tests from
zeppelin-web-angular:For manual verification in the Angular UI, use a paragraph that emits the following tab-separated table output:
x, Y Axis toy, and Group togroup.size. Point sizes should increase from x=1 to x=3 even though all Y values are equal.alternate. The size ordering should reverse while point positions and group colors remain unchanged.10), and the legend should retain groups A/B without an additional Size legend.Questions: