Skip to content

security: pingntlm forces InsecureSkipVerify and re-sends Basic auth on every redirect #32

Open

Description

@aspratt

Found by the security second review of #11 on 2026-10-20. This is pre-existing and wasn't introduced by #11.

  • pkg/provider/pingntlm/pingntlm.go:81-86 hard-codes InsecureSkipVerify: true in Authenticate. That overrides the account's SkipVerify, so TLS verification is always off on the NTLM path.
  • CheckRedirect re-applies SetBasicAuth on every redirect, whatever the target host, so credentials can be sent to a redirect target on a different host.

Severity: Medium. Fix: honour SkipVerify, and send Basic only to the original host.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions