Skip to content

uplift: go-ntlmssp CVE-2026-32952 (ADFS/NTLM path) #7

Closed

Description

@aspratt

Nature

security (already public CVE only)

What and why

Component: github.com/Azure/go-ntlmssp. Pinned to the 2021 pseudo-version v0.0.0-20211209120228-48547f28849e.
Current → target: → v0.1.1 (the fixed release; to be confirmed at stage 3).
Reason: CVE-2026-32952, an out-of-bounds panic on a malicious NTLM challenge. A hostile or MITM'd endpoint could crash saml2aws during NTLM authentication. To confirm which providers reach it at stage 3 (likely pingntlm and the ADFS/NTLM path).

Impacted version

Upstream: unknown – v2.36.19 (every release with the 2021 pin).
Confirmed on (fork tag): to be done at stage 3 (govulncheck plus a reachability check).

Specific risk and its test

Risk: the bump changes NTLM negotiation behaviour for real ADFS/PingNTLM users.
Test: a regression test that feeds a malformed NTLM challenge (from the CVE advisory) through the NTLM path. It must panic or fail on the old pin and fail cleanly on the new one. The existing pkg/provider/pingntlm tests and the harness must still pass. govulncheck ./... must be clean for this CVE.

Upstream links

Issue: Versent#1524

Process notes

Public CVE, so a public issue is allowed (PROCESS.md, Security items). Stage 4: accepted (maintainer batch 1, 2026-10-20). Starts after the harness isolation record lands.

Activity

  1. added
    type:upliftToolchain, dependency, CI or platform currency
    nature:securityConfidentiality, integrity or credential safety
    severity:S2Common configuration broken, or a hard workaround
    on Oct 20, 2026
  2. aspratt commented on Oct 20, 2026

    @aspratt
    OwnerAuthor

    Stage 4 decisions (maintainer, 2026-10-20), behaviour changes in v0.1.1:

    • Basic fallback: stays OFF (no AllowBasicAuth). Safer default; release-note it.
    • Merge requirement: a mock NTLMv2 success-path test (including a DOMAIN\\user case) before merge. A live ADFS/PingNTLM check becomes a follow-up record, since no environment exists.
    • Also flagged: Negotiate-only (Kerberos) challenges are no longer completed. Release-note it.
      PR: uplift: go-ntlmssp v0.1.1 for CVE-2026-32952 (#7) #11 (draft).
  3. added and removed on Oct 20, 2026
  4. added a commit that references this issue on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    nature:securityConfidentiality, integrity or credential safetyprovider:pingntlmpkg/provider/pingntlmseverity:S2Common configuration broken, or a hard workaroundstatus:in-progressStage 5: change being madetype:upliftToolchain, dependency, CI or platform currency

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions