Repository navigation
fix: list-roles empty for single-role users (#14) - #21
Merged
Merged
Conversation
…14) A single-role user is 302ed straight to the console, so the role chooser never renders and ParseAWSAccounts returned no accounts. When the parse yields nothing after a redirect, build accounts from the assertion's roles, grouped by account id. TestListRolesSingleRole is now required.
…oops (#14) Fall back to assertion roles only when the final response is < 400, and restore Go's 10-redirect cap that the custom CheckRedirect dropped.
list-roles always posts to the real AWS sign-in page, which the offline moto lane can't reach, so the test skips unless E2E_TARGET=aws and stays required in e2e-aws.
Owner
Author
|
Pushed a419587. TestListRolesSingleRole now skips unless E2E_TARGET=aws, so it stays required in the e2e-aws lane and no longer fails the offline moto lane. make e2e and make e2e-aws are running at a419587; results will follow here and in #12. The Build failures on this head are the known retired Playwright CDN (404 on playwright-1.47.2 driver download in pkg/provider/browser). master fails the same way, and #10 fixes it. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record: #14 (bug × functional × S2).
A single-role user is 302ed to the console, so no role chooser renders and
list-rolesprinted nothing with exit 0. When the chooser parse yields no accounts after a redirect, accounts are now built from the assertion's roles, grouped by account id. Multi-role users who get the chooser see no change.TestParseAWSAccountsSingleRoleRedirect. The e2eTestListRolesSingleRoleis now required.Questions (conservative choice already in code): the label is
Account: <id>because the assertion carries no alias; the fallback also applies to a multi-role redirect that returns zero accounts, which used to fail with "No accounts available".