Repository navigation
Conversation
…u removal (do not merge) Tracking only: the umbrella PR's single file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJrQUDVVQMG6z1k4eszgth
|
Initial automated review · Aster Hi @satran004, thanks for the PR! 🙏 This is an automatic first check by an AI reviewer. It does not replace maintainer review and may be wrong. Reviewed commit: I reviewed this draft as a tracking plan. Issues found:
Suggestions:
Not tested: I checked the plan, source, and CI logs without running builds, tests, or reports. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DONT MERGE. Tracking PR for the ledger-cbor reader, the Dijkstra models and the Amaru removal across CCL (bloxbean/cardano-client-lib), Yaci and Yano. Tick items as they land.
Status (2026-11-09)
4fd977b2, NDC01d11b7c), with the type-6 fix: CBOR 43,365/43,434, ledger rules 290 scenarios, UPLC 1,064, turbo 3,997 budgets — identical per sample to the previous run.ledger-cborfor CCL's models, Yaci's serializers and Yano's strict package; leftovers listed under "Follow-ups".8811854a6onfeat/ledger-cbor-reader, reviewed by both.Decisions needed before release
6176e413); released nodes read headers definite-onlybyte[]fields (array equality by reference) + 1 minor: fix, or accept in Sonarmain; done on the reader in yaci#244 (32726dc5), ADR 0003 r11Phase A — can merge now
main, wait for CI, merge0.5.0-pre16-SNAPSHOTonnext(needed before the branch merges:nextsays0.5.0-pre15, already released)Phase B — the release chain
masterfeat/ledger-cbor-reader(draft; 21 onnext, incl. the metadata fix): CCL pre8; native-image build; mark ready; mergefeat/ledger-cbor-reader(draft; 30 onmainincl. the type-6 fix): rebase after Phase A; CCL pre8, Yaci pre16;conway3.blockfixture; four reports at the newest pins; Fable + Codex; mark ready; mergeFollow-ups (not blocking; issues to file on approval)
CCL
NativeScript.deserializeScriptRef,PlutusScript.deserializeScriptRef,ReferenceScriptUtil.deserializeScriptRefeach read[type, script](V4 accepted by one, rejected by another) — candidate for pre8, as it adds public APIRawItems.indefiniteRecordsAllowedcompares eras outsideEraSpec(ADR 0003 I2)tools/reader-diffOutcomeDiffrecursion on deep unequal inputsYaci
BlockSerializerDijkstra tx parts by position;AnchorSerializer.deserializeDI;Redeemer/Credential/StakeCredentialmodel readers (tag 6 → null;intValue()wrap); placeholderBlockSerializerTestYano (all pre-existing on
main)YaciUtxoHistoryDecoder) and scripts API (ScriptResource) hash/return re-encoded native scripts; differs for non-canonical encodingsConwayTxInfoTranslatorrejects bignum tag-30 rationals that validation acceptsWitnessValidationRulereads reference scripts by hand and swallows errors;ProposalParamUpdateKeys,SyncBlock,TxIdentityre-read positionsDefiniteLengthCbor(Scalus workaround) cites no upstream issue; the 00280 alias has no test that fails when the fixture changesisMultiAssetSmallEnough: addressed in feat(ledger-rules): strict decoding through CCL's ledger-cbor reader (ADR 0003, M7c) #244 (6b0d0196e), close on merge; Dijkstra era support (experimental): ledger prerequisites #239 Dijkstra prerequisites; Low priority: check the conformance mutants against the Haskell ledger #242 Haskell oracleReported upstream offline: NDC 00280's expected name; dataset label
bootstrap-witnesses-empty; the 64 aux-data samples.