Repository navigation
feat: isolation, runtime and runtimes fields for pool scheduling - #1
Conversation
Additive fields in agent.proto for pool scheduling: EnrollRequest.isolation = 8, HeartbeatRequest.isolation = 4, StartRunner.runtime = 7, BackendCapability.runtimes = 3. Pin the remote buf plugins to the versions the committed code was generated with, because the unpinned connect plugin now emits connectrpc.com/connect/v2 while go.mod stays on v1. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64536787ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| int32 max_runners = 7; | ||
| // Isolation the host offers for runners: "container", "sandboxed_container" | ||
| // (Docker with the gVisor runsc runtime) or "vm". | ||
| string isolation = 8; |
There was a problem hiding this comment.
When a host provides multiple backends—for example Docker alongside Tart or Firecracker, which the repeated available_backends field permits—this scalar can advertise only one of container, sandboxed_container, or vm. The scheduler will consequently treat that host as ineligible for jobs requiring any unreported mode even though the corresponding backend is available. Represent isolation as a repeated capability or associate it with each BackendCapability, and mirror that representation in heartbeats.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
The server cannot tell which hosts offer gVisor or VM isolation, nor ask the agent for a specific container runtime, so pool runners cannot be placed on the right hosts.
Solution
Additive proto fields for v0.2.0, with buf plugins pinned so generated code stays reproducible.
Major Changes
EnrollRequest.isolation = 8,HeartbeatRequest.isolation = 4,StartRunner.runtime = 7,BackendCapability.runtimes = 3buf.gen.yamlpinsprotocolbuffers/go:v1.36.12andconnectrpc/go:v1.19.1🤖 Generated with Claude Code