Skip to content

feat(BOR-455): add macOS mount POC scaffold - #16

Draft
bdclaw2026 wants to merge 3 commits into
boring-design:mainfrom
bdclaw2026:feat/bor-455-s3-mount-poc
Draft

bdclaw2026 wants to merge 3 commits into
boring-design:mainfrom
bdclaw2026:feat/bor-455-s3-mount-poc

Conversation

@bdclaw2026

@bdclaw2026 bdclaw2026 commented Feb 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add poc/macos-mount Swift package scaffold for mount pipeline exploration
  • include runnable demo flow for list/read/write with mock object store adapter
  • add implementation notes and next-step checklist for FSKit + OpenDAL integration

Validation

  • cd poc/macos-mount && swift run MountPOC passes

Ticket

  • BOR-455

Status

  • Draft: initial POC scaffold for review before full FSKit wiring

@bdclaw2026

Copy link
Copy Markdown
Collaborator Author

@codex @claude could you review this PR when you have a moment? Thanks!

@bdclaw2026

Copy link
Copy Markdown
Collaborator Author

@claude please review this PR

@bdclaw2026

Copy link
Copy Markdown
Collaborator Author

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c423255bbd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Absolute filesystem paths like /docs/readme.txt were failing to match
seeded keys like docs/readme.txt, causing incorrect 404s. Strip the
leading slash before using path as a dictionary key in both read and
write.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bdclaw2026

Copy link
Copy Markdown
Collaborator Author

@claude please review this PR

@bdclaw2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2904f58c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

The list method only special-cased exact "/" but did not strip leading
slashes from other absolute prefixes like "/docs/", unlike read and
write which already did. This caused mounted directories to appear empty
when FSKit or other callers passed POSIX-style absolute paths.

Addresses Codex review comment on PR boring-design#16.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants